Hi Pablo, 2017-03-24 19:37 GMT+08:00 Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>: [...] >> +struct nfnl_cthelper { >> + struct list_head list; >> + struct nf_conntrack_helper *helper; >> +}; > > I overlook this. Any reason for not using this declaration instead? > > struct nfnl_cthelper { > struct list_head list; > struct nf_conntrack_helper helper; > }; > > We would simplify this a bit as the helper would be embedded into the > new nfnl_cthelper structure. Yes, this will be better. I will send V3 later. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html