On Tue, Mar 21, 2017 at 10:54 PM, Eric Leblond <eric@xxxxxxxxx> wrote: > Hello, > > Thanks for the report and the patch. I'm not sure of your > implementation. Can you test with the patch to follow ? > > On Mon, 2017-03-20 at 10:31 +0200, Alexandru Ardelean wrote: >> This is a bit zealous to fix like this, but it seems to work. >> >> The crash was reproduced on ppc32, with GCC 5.4 & musl libc 1.1.16. >> >> And also on LEDE (mips_24kc and ARM): >> https://github.com/openwrt/packages/issues/4123 >> https://github.com/openwrt/packages/issues/4090 >> >> I personally saw it on ppc32. >> The offending code was in `pluginstance_alloc_init()` line 671: >> ``` >> memcpy(pi->id, pi_id, sizeof(pi->id)); >> ``` > > Thanks in advance, > -- > Eric Leblond <eric@xxxxxxxxx> Hey, Thanks for the response. Will test out your patch & come back. After submitting mine, there was a similar discussion on one of the Github threads [to use strncpy()/strlcpy()]. A few questions: 1) would strlcpy(d,s,len) be better [here & in general] ? [since it guarantees a null-char at the end of `len`] ? 1a) maybe it could be considered to replace strncpy() in more places [where the case is appropriate] 2) any thoughts on sanitizing the use of ULOGD_MAX_KEYLEN ? ; general gist of it would be #define ULOGD_MAX_KEYLEN 32 and remove any `ULOGD_MAX_KEYLEN+1` or `ULOGD_MAX_KEYLEN-1` ; which sort of seemed confusing ; and combined with strlcpy() it should give an overall more robust approach Thanks Alex -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
