On Tue, Mar 21, 2017 at 11:00:02PM +0800, Liping Zhang wrote: > Hi Pablo, > > 2017-03-21 18:34 GMT+08:00 Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>: > > On Sun, Mar 19, 2017 at 10:36:00PM +0800, Liping Zhang wrote: > >> From: Liping Zhang <zlpnobody@xxxxxxxxx> > >> > >> So we can modify the nf_conntrack_expect_policy directly, the next patch > >> will need this. > > > > I'm missing why you need this. > > Because I want to modify the nf_conntrack_expect_policy directly when > do update expect policy in nfct_helper. > > I saw you make a cast type to do this: > policy = (struct nf_conntrack_expect_policy *) &helper->expect_policy[i]; > (refer to http://patchwork.ozlabs.org/patch/741528/) > > But when I'm working on this, I'm not sure "cast type" is proper or not. > So I just remove the const qualifier. I see. I prefer we just cast away the type from the single spot in nfnl_cthelper. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
