On Tue, Mar 21, 2017 at 12:35 AM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > On 03/20/2017 01:15 PM, Feng Gao wrote: > >>>> From: Gao Feng <fgao@xxxxxxxxxx> >>>> >>>> In the commit <93557f53e1fb> ("netfilter: nf_conntrack: nf_conntrack >>>> snmp >>> >>> >>> >>> Angle brackets not needed. :-) >>> The commit citing style is the same as for the Fixes: tag. >> >> >> The checkpatch.pl reports the following error, if remove the angle >> brackets. > > > Because it stops recognizing the commit ID! :-) > >> ERROR: Please use git commit description style 'commit <12+ chars of >> sha1> ("<title line>")' - ie: 'commit fatal: ambig ("evision or path >> not in the working tree.")' > > > So check the patch in the correct tree because that seems to be the > problem... Angle brackets are surely not required. Actually I didn't add the angle brackets firstly, but it fail to pass the check_patch.pl check. So I had to modify it. Ok, I removed the angle brackets now, just ignored the error report of check_patch.pl. Best Regards Feng > >> #7: >> In the commit 93557f53e1fb ("netfilter: nf_conntrack: nf_conntrack snmp >> >> total: 1 errors, 0 warnings, 0 checks, 27 lines checked >> >> >> Regards >> Feng > > > [...] > > MBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html