From: Florian Westphal <fw@xxxxxxxxx> Date: Mon, 13 Mar 2017 17:38:17 +0100 > Andreas reports kernel oops during rmmod of the br_netfilter module. > Hannes debugged the oops down to a NULL rt6info->rt6i_indev. > > Problem is that br_netfilter has the nasty concept of adding a fake > rtable to skb->dst; this happens in a br_netfilter prerouting hook. > > A second hook (in bridge LOCAL_IN) is supposed to remove these again > before the skb is handed up the stack. > > However, on module unload hooks get unregistered which means an > skb could traverse the prerouting hook that attaches the fake_rtable, > while the 'fake rtable remove' hook gets removed from the hooklist > immediately after. > > Fixes: 34666d467cbf1e2e3c7 ("netfilter: bridge: move br_netfilter out of the core") > Reported-by: Andreas Karis <akaris@xxxxxxxxxx> > Debugged-by: Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Florian Westphal <fw@xxxxxxxxx> > --- > David, I know you *love* the fake_rtable turd, but I think > this patch should go directly via net and not nf tree. > After all, this adds to bridge and removes from the netfilter part. Ok, applied and queued up for -stable. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html