Re: [PATCH 1/2 nf] netfilter: nft_set_bitmap: keep a list of dummy elements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pablo,

2017-03-13 20:27 GMT+08:00 Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>:
> Element comments may come without any prior set flag, so we have to keep
> a list of dummy struct nft_set_ext to keep this information around. This
> is only useful for set dumps to userspace. From the packet path, this
> set type relies on the bitmap representation. This patch simplifies the
> logic since we don't need to allocate the dummy nft_set_ext structure
> anymore on the fly at the cost of increasing memory consumption because
> of the list of dummy struct nft_set_ext.

If I didn't misunderstand it, I think after introducing the dummy nft_set_ext,
the nft_bitmap_estimate() should also be updated? i.e.:

1. est->size should be recalculated
2. est->space should be changed to NFT_SET_CLASS_O_N
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux