On Fri, Mar 10, 2017 at 06:13:52PM +0100, Phil Sutter wrote:
[...]
> diff --git a/tests/py/inet/fib.t.payload b/tests/py/inet/fib.t.payload
> index f5258165384dc..e928a19649133 100644
> --- a/tests/py/inet/fib.t.payload
> +++ b/tests/py/inet/fib.t.payload
> @@ -20,3 +20,13 @@ __map%d test-ip 0
> ip test-ip prerouting
> [ fib daddr . iif type => reg 1 ]
> [ lookup reg 1 set __map%d dreg 0 ]
> +
> +# fib daddr oif exists
> +ip test-ip prerouting
> + [ fib daddr oif => reg 1 ]
Instead of casting out the flag like this:
@@ -173,7 +173,7 @@ nftnl_expr_fib_snprintf_default(char *buf, size_t size,
{
struct nftnl_expr_fib *fib = nftnl_expr_data(e);
int len = size, offset = 0, ret, i;
- uint32_t flags = fib->flags;
+ uint32_t flags = fib->flags & ~NFTA_FIB_F_PRESENT;
static const struct {
int bit;
const char *name;
I think it would be better if we have a different fib output for the
present case, eg.
[ fib daddr oif present => reg 1 ]
So we can see from --debug=netlink this generates bytecode to check
the presence.
Same thing applies to:
# exthdr hbh exists
ip6 test-ip6 input
[ exthdr load 1b @ 43 + 0 => reg 1 ]
[ cmp eq reg 1 0x00000001 ]
Instead, I'd suggest something like:
[ exthdr 43 present => reg 1 ]
[ cmp eq reg 1 0x00000001 ]
You would need to send a follow up to amend test for 3/5, but that
should be no problem.
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
