Re: [PATCH nf-next] netfilter: nf_tables: validate the expr explicitly after init successfully

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 05, 2017 at 09:02:23PM +0800, Liping Zhang wrote:
> From: Liping Zhang <zlpnobody@xxxxxxxxx>
> 
> When we want to validate the expr's dependency or hooks, we must do two
> things to accomplish it. First, write a X_validate callback function
> and point ->validate to it. Second, call X_validate in init routine.
> This is very common, such as fib, nat, reject expr and so on ...
> 
> It is a little ugly, since we will call X_validate in the expr's init
> routine, it's better to do it in nf_tables_newexpr. So we can avoid to
> do this again and again. After doing this, the second step listed above
> is not useful anymore, remove them now.

Applied, thanks Liping.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux