Re: [PATCH nf 2/2] netfilter: nf_ct_expect: Change __nf_ct_expect_check() return value.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 23, 2017 at 05:08:54PM -0800, Jarno Rajahalme wrote:
> Commit 4dee62b1b9b4 ("netfilter: nf_ct_expect: nf_ct_expect_insert()
> returns void") inadvertently changed the successful return value of
> nf_ct_expect_related_report() from 0 to 1 due to
> __nf_ct_expect_check() returning 1 on success.  Prevent this
> regression in the future by changing the return value of
> __nf_ct_expect_check() to 0 on success.

We used to return 0 via __nf_ct_expect_check() in the past, not
anymore for a while. So even if this doesn't fix anything, I'm fine
with this change to prevent more sloppy updates on this code.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux