Re: [PATCH nft 2/2] tests: py: Use stateless option on tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 18, 2017 at 07:02:53PM +0100, Pablo Neira Ayuso wrote:
> On Tue, Jan 17, 2017 at 01:44:54PM -0200, Elise Lennion wrote:
> > To don't trigger false errors because of unrelated traffic on the
> > tested machine.
> > 
> > Tests, which have rules with counter and 'ok' result, are updated to
> > avoid new Warnings.
> 
> Also applied, thanks.
> 
> > diff --git a/tests/py/ip/flowtable.t b/tests/py/ip/flowtable.t
> > index aea57c3..41d5d3b 100644
> > --- a/tests/py/ip/flowtable.t
> > +++ b/tests/py/ip/flowtable.t
> > @@ -2,4 +2,4 @@
> >  
> >  *ip;test-ip;input
> >  
> > -flow table xyz { ip saddr timeout 30s counter packets 0 bytes 0};ok
> > +flow table xyz { ip saddr timeout 30s counter};ok
> 
> This reminds something: From flow tables, counter, quota, and limit
> must always be printed in their stateless version.
> 
> A simple way to fix this is to turn stateless_output into unsigned
> int, so you can stateless_output++ before printing the statement from
> flow_stmt_print().

As well stateless_output-- after printing it, to restore the counter
to its previous state.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux