Re: [PATCH nf] netfilter: nf_tables: fix oob access

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> On Tue, Dec 13, 2016 at 01:59:33PM +0100, Florian Westphal wrote:
> > BUG: KASAN: slab-out-of-bounds in nf_tables_rule_destroy+0xf1/0x130 at addr ffff88006a4c35c8
> > Read of size 8 by task nft/1607
> > 
> > When we've destroyed last valid expr, nft_expr_next() returns an invalid expr.
> > We must not dereference it unless it passes != nft_expr_last() check.
> > 
> > Signed-off-by: Florian Westphal <fw@xxxxxxxxx>
> > ---
> >  I dislike nft_expr_last() naming, it doesn't return last
> >  valid expression but an invalid address...
> 
> Sure, send a patch for this, or simply update this oneliner in v2,
> your call.  Thanks.

Ok, I will try to come up with a better name and send a patch once
next opens again. (what about rename to nft_expr_end()?)
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux