On Mon, Nov 28, 2016 at 05:49:58PM +0100, Anatole Denis wrote: > Le 28/11/2016 12:39:05, Pablo Neira Ayuso a écrit : [...] > I believe this error is not the best way to handle this issue. I > sent a patch to the list with a proposed change to catch it earlier, > removing the need to check for it here. In case that other patch is > refused, I will send v2 with this check added. I see, you're refering to the patchset you sent later on. [...] > The case for a lookup/inverse lookup into a nonexistent set is > tested in ip/sets.t and ip6/sets. (somewhere in patches 3 and 4). > I'll send a v2 of these tests with a test for datatype mismatch > added. Send me a follow up patch for this if you think this can help us increase test coverage, that will be appreciated. > Considering the previous remarks (and the other patches), do > you think I still should change the error handling code ? I think this is fine so I applied your patchses. The check for datatype == NULL was not going to the core of the problem indeed. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
