On Mon, Nov 28, 2016 at 11:27:49AM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> > Notify on depleted quota objects. The NFT_QUOTA_F_DEPLETED flag
> > indicates we have reached overquota.
> >
> > Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
> > - nft_quota_do_eval(priv, regs, pkt);
> > + if (nft_overquota(priv, pkt) ^ nft_quota_invert(priv)) {
> > + if (test_and_set_bit(NFT_QUOTA_F_DEPLETED, &priv->flags)) {
> > + nft_obj_notify(nft_net(pkt), nft_chain(pkt)->table,
> > + obj, 0, 0, NFT_MSG_NEWOBJ,
> > + nft_pf(pkt), 0, GFP_ATOMIC);
>
> I suspect this should be !test_and_set_bit()?
>
> Or does this really want to call notify for every overquota hit?
That's right, my test here was just checking for the first event then
stop. Will fix up this, thanks for reviewing.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
