Re: [PATCH net-next 1/1] netfilter: xt_multiport: Fix wrong unmatch result with multiple ports

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 25, 2016 at 12:11 PM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> On Fri, 2016-11-25 at 11:58 +0800, fgao@xxxxxxxxxx wrote:
>> From: Gao Feng <fgao@xxxxxxxxxx>
>>
>> I lost one test case in the commit for xt_multiport.
>> For example, the rule is "-m multiport --dports 22,80,443".
>> When first port is unmatched and the second is matched, the curent codes
>> could not return the right result.
>> It would return false directly when the first port is unmatched.
>>
>> Fixes: dd2602d00f80 ("netfilter: xt_multiport: Use switch case instead
>> of multiple condition checks")
>>
>> Signed-off-by: Gao Feng <fgao@xxxxxxxxxx>
>
> Note that the Fixes: tag should immediately precede your
> 'Signed-off-by:'
>
> No empty new line between the two tags.

OK, I get it and will send another update.

Regards
Feng

>
> Thanks.
>
>


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux