Hi Anders, 2016-11-21 16:57 GMT+08:00 Anders K. Pedersen | Cohaesio <akp@xxxxxxxxxxxx>: [...] >> nla[NFTA_SET_TIMEOUT] should be kept indent consistent with >> be64_to_cpu. >> You can add some spaces after tab. > > The indentation is deliberate, because I don't want to give the > impression that nla[] is an argument to the be64_to_cpu() function. > > I looked through the file to see how similar indentation issues was > handled elsewhere. There seems to be a preference for just exceeding > the 80 character per line limit (I found lines up to 107 characters), > but I did find one place (case NFT_GOTO in nf_tables_check_loops()) > that use the same style as I do here. Yes, after a closer look, I also find that it's not easy to deal with the indentation in this case. And sorry for not realizing this issue at the first glance. So everything is fine. Thanks > > So I could switch to just using long lines, if that is preferred, and > just ignore the checkpatch.pl warning about it. The longest new line > would be 99 characters, which is less than what already exists in the > file. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
