On Tue, Nov 15, 2016 at 08:50:10PM +0100, Pablo Neira Ayuso wrote:
> On Tue, Nov 15, 2016 at 05:22:38PM -0200, Elise Lennion wrote:
> > Error messages in nft should start with "syntax error" to keep
> > consistency. A new function add_syntax_error() was created to add this
> > prefix when necessary.
>
> Probably you can just add EREC_SYNTAX_ERROR to enum
> error_record_types, then add:
>
> #define syntax_error(loc, fmt, args...) \
> erec_create(EREC_SYNTA_ERROR, (loc), (fmt), ## args)
Actually, git grep "erec_queue(error(" tells me all:
erec_queue(error(...
occur in parser_bison.y, so we can just update #define error in erec.h
You will have to define something like __error, which doesn't include
the "syntax error" string, as bison is already including it in this
spot below:
static void yyerror(struct location *loc, void *scanner,
struct parser_state *state, const char *s)
{
erec_queue(__error(loc, "%s", s), state->msgs);
}
So it will be a simple patch in the end.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
