Re: [PATCH nf-next] netfilter: nf_tables: simplify the basic expressions' init routine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 06, 2016 at 09:15:51PM +0800, Liping Zhang wrote:
> From: Liping Zhang <zlpnobody@xxxxxxxxx>
> 
> Some basic expressions are built into nf_tables.ko, such as nft_cmp,
> nft_lookup, nft_range and so on. But these basic expressions' init
> routine is a little ugly, too many goto errX labels, and we forget
> to call nft_range_module_exit in the exit routine, although it is
> harmless.
> 
> Acctually, the init and exit routines of these basic expressions
> are same, i.e. do nft_register_expr in the init routine and do
> nft_unregister_expr in the exit routine.
> 
> So it's better to arrange them into an array and deal with them
> together.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux