On Friday, October 28, 2016 5:50:31 PM CEST Florian Westphal wrote: > Arnd Bergmann <arnd@xxxxxxxx> wrote: > > The newly added nft fib code produces two warnings: > > > > net/ipv4/netfilter/nft_fib_ipv4.c: In function 'nft_fib4_eval': > > net/ipv4/netfilter/nft_fib_ipv4.c:80:6: error: unused variable 'i' [-Werror=unused-variable] > > net/ipv4/netfilter/nft_fib_ipv4.c: In function ‘nft_fib4_eval’: > > net/ipv4/netfilter/nft_fib_ipv4.c:137:6: error: ‘oif’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > > > > The first one is obvious as the only user of that variable is > > inside of an #ifdef, but the second one is a bit trickier. > > It is clear that 'oif' is uninitialized here if neither > > NFTA_FIB_F_OIF nor NFTA_FIB_F_IIF are set. > > > > I have no idea how that should be handled, this patch just > > returns without doing anything, which may or may not be > > the right thing to do. > > It should be initialized to NULL. Ok, I had considered that, but wasn't sure if ->nh_dev could ever be NULL, as that would then get dereferenced. Arnd -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
