Re: [PATCH nf-next v2] netfilter: conntrack: simplify init/uninit of L4 protocol trackers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 28, 2016 at 10:47:52AM +0200, Pablo Neira Ayuso wrote:
> On Fri, Oct 28, 2016 at 10:42:09AM +0200, Davide Caratti wrote:
> > modify registration and deregistration of layer-4 protocol trackers to
> > facilitate inclusion of new elements into the current list of builtin
> > protocols. Both builtin (TCP, UDP, ICMP) and non-builtin (DCCP, GRE, SCTP,
> > UDPlite) layer-4 protocol trackers usually register/deregister themselves
> > using consecutive calls to nf_ct_l4proto_{,pernet}_{,un}register(...).
> > This sequence is interrupted and rolled back in case of error; in order to
> > simplify addition of builtin protocols, the input of the above functions
> > has been modified to allow registering/unregistering multiple protocols.
> 
> Applied, thanks Davide.

Wait, let me get back to you with a bit more feedback. There are a few
nitpicks, and looking at this again, I guess we can improve
maintainability by splitting code into smaller functions.

Will get back to you in a while with more feedback, sorry,
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux