On Fri, Sep 30, 2016 at 07:47:49PM +0200, Pablo Neira Ayuso wrote: > On Fri, Sep 30, 2016 at 06:05:34PM +0200, Arnd Bergmann wrote: > > The newly added nft_range_eval() function handles the two possible > > nft range operations, but as the compiler warning points out, > > any unexpected value would lead to the 'mismatch' variable being > > used without being initialized: > > > > net/netfilter/nft_range.c: In function 'nft_range_eval': > > net/netfilter/nft_range.c:45:5: error: 'mismatch' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > > > This can be trivially avoided by added a 'default:' clause. > > Applied this patch, I took Aaron's and Pai's patches instead. Looking at this again, I know uninitialized_var() has been discussed as not nice since it can hide bugs behind. But if I fix the existing code to validate priv->op from _init() (this is currently broken), we can probably use this so save extra code in the packet path for a case that is not going to happen. Let me know, thanks! -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
