Re: [PATCH v3 2/2] netfilter: Create revision 2 of xt_hashlimit to support higher pps rates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 25, 2016 at 01:35:01PM +0200, Pablo Neira Ayuso wrote:
> On Thu, Sep 22, 2016 at 02:39:45PM -0400, Vishwanath Pai wrote:
> > Thanks for pointing this out, I will reorder the fields to:
> > 
> > struct hashlimit_cfg2 {
> > 	__u64 avg;    /* Average secs between packets * scale */
> > 	__u64 burst;
> > 	__u32 mode; /* bitmask of XT_HASHLIMIT_HASH_* */
> > 
> > This should fix the hole and avoid padding.
> 
> I have manually mangled this here, and applied, to get this change in
> this in merge window.
> 
> I also have to revert the rename of XT_HASHLIMIT_SCALE to
> XT_HASHLIMIT_SCALE_v1. This is exposed through uapi, this change would
> break userspace.

This requires that you rebase and resubmit your userspace patches for
iptables though.

Thanks for your patience to get this in, btw.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux