On Thu, Sep 22, 2016 at 09:16:07AM -0700, Eric Dumazet wrote:
> On Thu, 2016-09-22 at 16:58 +0200, Pablo Neira Ayuso wrote:
> > attributes")
> >
> > Always use 12 bytes commit-ids. 4da449a is too short, given the number
> > of changes we're getting in the kernel tree, this may become ambiguous
> > at some point so it won't be unique.
> >
> > You can achieve this via: git log --oneline --abbrev=12
>
> and Documentation/SubmittingPatches has these tips :
>
>
> You should also be sure to use at least the first twelve characters of the
> SHA-1 ID. The kernel repository holds a *lot* of objects, making
> collisions with shorter IDs a real possibility. Bear in mind that, even if
> there is no collision with your six-character ID now, that condition may
> change five years from now.
>
> If your patch fixes a bug in a specific commit, e.g. you found an issue using
> git-bisect, please use the 'Fixes:' tag with the first 12 characters of the
> SHA-1 ID, and the one line summary. For example:
>
> Fixes: e21d2170f366 ("video: remove unnecessary platform_set_drvdata()")
>
> The following git-config settings can be used to add a pretty format for
> outputting the above style in the git log or git show commands
>
> [core]
> abbrev = 12
> [pretty]
> fixes = Fixes: %h (\"%s\")
>
>
Duly noted, thanks.
In this case, it was not referred to a fix but an extension of the
older patch to other files with the same problem.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
