Gao Feng <fgao@xxxxxxxxxx> wrote: [ drop netdev & coreteam from cc list ] > On Sat, Sep 17, 2016 at 1:18 AM, Florian Westphal <fw@xxxxxxxxx> wrote: > > > Gao Feng <fgao@xxxxxxxxxx> wrote: > > > > [ 23.465616] ------------[ cut here ]------------ > > > > [ 23.466477] WARNING: CPU: 0 PID: 1225 at net/netfilter/nf_conntrack_ > > seqadj.c:232 > > > > nf_ct_seq_offset+0x7a/0x9a > > > > [ 23.468458] Missing nfct_seqadj_ext_add() setup call > > > > > > > > > > It should be that nf_ct_add_synproxy failed and the seqadj extentision is > > > not added. > > > > Note that nfct_synproxy_ext_add always returns NULL if > > CONFIG_NETFILTER_SYNPROXY=n > > > > The warning should also be removed. > > > When CONFIG_NETFILTER_SYNPROXY=NULL, it will not reach > nfct_synproxy_ext_add, because nfct_synproxy also returns the NULL. Right. Apologies, I did not realize this report is about an old revision of the patch that was never applied to the tree. So I think we can just ignore this report. [ its this patch: https://patchwork.ozlabs.org/patch/665102/ ] > I am not clear why the commit breaks conntrack when if SYNPROXY=n based on > my response above. Its fine, forget about it. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html