On Thu, Sep 01, 2016 at 07:01:51PM +0800, Feng Gao wrote: > On Thu, Sep 1, 2016 at 6:20 PM, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > On Thu, Sep 01, 2016 at 10:26:08AM +0800, Feng Gao wrote: > >> On Thu, Sep 1, 2016 at 10:14 AM, <fgao@xxxxxxxxxx> wrote: [...] > >> Sorry, I forget one point. I also remove some codes which are > >> commented out by #if0. > > > > Please, do this in a separated patch. Thanks. > > Done. > I thought the "#if 0" change is very tiny, and it did not deserve one commit. > > Now I get it. It needs one separate commit, even though how tiny it is. Better split patches into logical changes. In general, if you end up describing two changes that don't relate each other in the patch description, then this usually means you need two patches. Thanks for addressing my feedback! -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
