On Fri, 2016-08-19 at 13:36 +0200, Florian Westphal wrote:
> Conntrack gc worker to evict stale entries.
...
> +
> + hlist_nulls_for_each_entry_rcu(h, n, &ct_hash[i], hnnode) {
> + tmp = nf_ct_tuplehash_to_ctrack(h);
> +
> + if (nf_ct_is_expired(tmp)) {
> + nf_ct_gc_expired(tmp);
> + expired_count++;
> + continue;
Same remark about hlist_nulls_for_each_entry_rcu() not 'safe' here
> + }
> + }
> +
> + rcu_read_unlock();
> + cond_resched();
This could use cond_resched_rcu_qs()
> + } while (++buckets < goal &&
> + expired_count < GC_MAX_EVICTS);
> +
> + if (gc_work->exiting)
> + return;
> +
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
