On Tue, Aug 16, 2016 at 12:21:24PM +0200, Carlos Falgueras García wrote: > diff --git a/src/expr.c b/src/expr.c > index e5c1dd3..7f32055 100644 > --- a/src/expr.c > +++ b/src/expr.c > @@ -203,6 +203,20 @@ const char *nftnl_expr_get_str(const struct nftnl_expr *expr, uint16_t type) > } > EXPORT_SYMBOL_ALIAS(nftnl_expr_get_str, nft_rule_expr_get_str); > > +bool nftnl_expr_cmp(const struct nftnl_expr *e1, const struct nftnl_expr *e2) > +{ > + if (e1->flags != e2->flags) > + return false; > + > + if (strcmp(e1->ops->name, e2->ops->name)) > + return false; > + if (e1->ops->cmp) > + return e1->ops->cmp(e1, e2); > + else > + return !memcmp(e1->data, e2->data, e1->ops->alloc_len); We cannot do memcmp() anymore, we have to add cmp() for each expression because of we have already discussed wrt. unset attributes. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html