Re: [PATCH 2/2, libnftnl] Use libnftnl comparators in all tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/12/2016 01:32 AM, Pablo Neira Ayuso wrote:
On Thu, Aug 11, 2016 at 03:25:07PM +0200, Carlos Falgueras García wrote:
-	cmp_nftnl_expr(rule_a,rule_b);
+	if (!nftnl_expr_cmp(rule_a, rule_b))
+		print_err("expressions mismatches:\n\texpr 1: %s\n\texpr 2: %s",
+			  expr2str(rule_a), expr2str(rule_b));

Better, add something like

                print_expr_mismatch(rule_a, rule_b);

I have called this 'test_assert_{expr,rule}()' for consistency with 'test_assert()'.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux