On Wed, Aug 10, 2016 at 01:56:32PM +0200, Carlos Falgueras García wrote: > On 08/10/2016 01:41 PM, Pablo Neira Ayuso wrote: > >>@@ -1025,10 +1033,16 @@ int nftnl_expr_foreach(struct nftnl_rule *r, > >> } > >> EXPORT_SYMBOL_ALIAS(nftnl_expr_foreach, nft_rule_expr_foreach); > >> > >>-struct nftnl_expr_iter { > >>- const struct nftnl_rule *r; > >>- struct nftnl_expr *cur; > >>-}; > > > >I have kept this structure definition here, we don't have to scroll up > >and down to get the context when looking at the iterators code. > > > >After my change, the patch looks even smaller. > > But we will need it at the next patch, so I will include these changes in > the patch : 2/4 - "Implement rule comparison". It is ok? You can place nftnl_rule_cmp() after the iterators, so you don't need this forward declaration. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html