Re: [PATCH 4/5, V2, nft] Simplify parser rule_spec tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/08/2016 04:54 PM, Pablo Neira Ayuso wrote:
On Mon, Aug 08, 2016 at 02:42:34PM +0200, Carlos Falgueras García wrote:
-position_spec		:	/* empty */
+rule_position		:	chain_spec
 			{
-				memset(&$$, 0, sizeof($$));
+				$$ = $1;
 			}
-			|	POSITION	NUM
+			|	chain_spec position_spec
 			{
-				memset(&$$, 0, sizeof($$));
-				$$.location	= @$;
-				$$.id		= $2;
+				$$ = $1;
+				handle_merge(&$$, &$2);
+			}
+			|	chain_spec error
+			{
+				erec_queue(error(&@2, "Expected `position' or nothing"),

In what case we display this error message after this patch?

When user try to use 'handle' with CMD_INSERT or CMD_ADD. The error was "use only `position' instead"

Please, include examples in your patch description.

Ok, I'll do.

You can also explicitly indicate that tests pass succesfully.

At V3 all tests will pass succesfully.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux