On Wed, Jul 20, 2016 at 08:31:13AM +0800, 高峰 wrote:
> Thanks Pablo.
>
> I had used the script "checkpatch.pl" to check the patch file.
> There was no indentation error reported.
>
> So could you give me more tails please or point one indentation error?
> Then I could correct it by myself next time.
I'm refering to this specifically:
static int function(int parameter1, struct another_structure *blah,
int parameter2, unsigned int parameter3);
^
It is just a comestic issue, but we consistently align function
parameters to the initial parens.
As I said, I have just manually fixed this here, so no problem, just
keep this in mind for the next time.
Another observation: You should bump patch version numbering in each
revision and keep some history on its evolution.
The area after the patch separator --- and before diff stats is good
to place volatile information that is only meaningful to the review
process, I mean something like this:
subsystem: Patch title.
Patch description...
Signed-off-by: Lucas Skywalker <trotacielos@xxxxxxxxxxxxx>
---
v3: Address comments from Chebakia on possible backward compatibility
issues.
v2: New parameter to control something.
v1: Initial patch.
include/net/netfilter/nf_tables.h | 25 ++-
...
diff --git a/include/net/netfilter/nf_tables.h b/include/net/netfilter/nf_tables.h
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
