On Fri, Jul 08, 2016 at 05:29:11PM +0100, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom <eric.engestrom@xxxxxxxxxx> > --- > > This can't compile without this macro… Is this header really used by anyone? > Should it be removed, to avoid bit-rot? Probably better to define something like: #define SCTP_BITMAP_LEN (256 / sizeof (u_int32_t)) and use it consistently all around the code, so we can get rid of these ARRAY_SIZE() from the uapi header. > --- > include/uapi/linux/netfilter/xt_sctp.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/uapi/linux/netfilter/xt_sctp.h b/include/uapi/linux/netfilter/xt_sctp.h > index 58ffcfb..e4410db 100644 > --- a/include/uapi/linux/netfilter/xt_sctp.h > +++ b/include/uapi/linux/netfilter/xt_sctp.h > @@ -3,6 +3,8 @@ > > #include <linux/types.h> > > +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr)[0]) > + > #define XT_SCTP_SRC_PORTS 0x01 > #define XT_SCTP_DEST_PORTS 0x02 > #define XT_SCTP_CHUNK_TYPES 0x04 > -- > 2.9.0 > -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
