David Laight <David.Laight@xxxxxxxxxx> wrote: > From: Pablo Neira Ayuso > > Sent: 06 July 2016 15:24 > > From: Florian Westphal <fw@xxxxxxxxx> > > > > increases struct size by 32 bytes (288 -> 320), but it is the right thing, > > else any attempt to (re-)arrange nf_conn members by cacheline won't work. > ... > > nf_conntrack_cachep = kmem_cache_create("nf_conntrack", > > sizeof(struct nf_conn), 0, > > - SLAB_DESTROY_BY_RCU, NULL); > > + SLAB_DESTROY_BY_RCU | SLAB_HWCACHE_ALIGN, NULL); > > What happens on systems with cache lines that are longer than 64 bytes? Sorry, I don't have a secret decoder ring. HWCACHE_ALIGN is used for several other net slab caches, including skbuff, so why is this a problem here? -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html