On Sun, Mar 06, 2016 at 10:33:11AM -0500, Peter Foley wrote: > When compiling with clang, the visibility attributes are ignored > since they are after the definition of the exported function. > > Fix this by moving the attribute declaration before the function. > > attr.c:439:1: error: attribute declaration must precede definition [-Werror,-Wignored-attributes] > EXPORT_SYMBOL(mnl_attr_put_u8); > ^ > ./internal.h:7:41: note: expanded from macro 'EXPORT_SYMBOL' > ^ > ./internal.h:6:35: note: expanded from macro '__visible' > ^ > attr.c:435:6: note: previous definition is here > void mnl_attr_put_u8(struct nlmsghdr *nlh, uint16_t type, uint8_t data) > ^ I don't like that we have to change coding style for this, but given many of you have follow up on this, I'm willing to help so I'm applying this. Thanks for your patience. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
