On Sat, Jun 18, 2016 at 6:12 PM, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> Hi Shivani,
>
> Thanks for following up on this, see comment below.
>
> On Sat, Jun 18, 2016 at 12:47:43AM +0530, Shivani Bhardwaj wrote:
>> Following the fixes for version check in iptables and nftables, make
>> conntrack-tools avoid generating false warning for Flex version greater
>> than 2.5.x.
>>
>> Signed-off-by: Shivani Bhardwaj <shivanib134@xxxxxxxxx>
>> ---
>> configure.ac | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index c541034..3bc5155 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -46,7 +46,7 @@ flex_major=`echo $flex_version| cut -d . -f 1`
>> flex_minor=`echo $flex_version| cut -d . -f 2`
>> flex_rev=`echo $flex_version| cut -d . -f 3`
>>
>> -if test "$flex_major" -eq "2" && test "$flex_minor" -eq "5" && test "$flex_rev" -ge "33"; then
>> +if (test "$flex_major" -eq "2" && test "$flex_minor" -eq "5" && test "$flex_rev" -ge "33") || (test "$flex_major" -eq "2" && test "$flex_minor" -gt "5") || test "$flex_major" -gt "2"; then
>> AC_MSG_RESULT([$flex_version. OK])
>> else
>> AC_MSG_WARN([flex version $flex_version found.
>
> I'm starting to think that it's better to get rid of this version
> check. This was introduced in 2008:
>
> ed50c34 ("add flex version warning (better with >= 2.5.33)")
>
> I can see RPM packages for 2.5.53 since 2008.
>
> The development of conntrack-tools a bit before that time, so I think
> it's better to nuke these checks, better since we have less code to
> maintain :)
>
Hi Pablo,
Just to avoid any confusion, should I be following up with patches for
iptables and conntrack-tools to completely remove this check? It is
already not there in nft. Please let me know.
Thank you.
> Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
