Hello, On Wed, 15 Jun 2016, Quentin Armitage wrote: > This series of patches arise from discovering that: > ipvsadm --start-daemon backup --mcast-group IPv6_address ... > would always fail. > > The first patch resolves the problem. The second and third patches are > optimizations that were noticed while investigating the original problem. > The fourth patch adds a lock which appears to have been omitted, and the > final patch adds the recently added sync daemon multicast parameters to > the log messages that are written when the sync daemons start. > > v2 fixes a compile error in a debug message identified by kbuild test > robot. Now compiles with CONFIG_IP_VS_DEBUG enabled. Patch 2/5 is modified > to correct the problem, and patch 3/5 is modifed to apply with the > modified patch 2/5. > > v3 incorporates changes suggested by Julian Anastasov. > Patch 1 now sets 'sock->sk->sk_bound_dev_if = ifindex' rather than setting > sin6_scope_id. Also remove the locks since unnecessary. > Patch 3 shortens the logged message in order not to exceed 80-char limit. > Patch 4 Removed, the locks aren't necessary > Patch 5 No longer changes indentation of existing pr_info. Also removes <> > around commit IDs in commit description. > Patches 1, 2, 3, 5 are updated to resolve coding style warnings, and all > pass with 0 errors, warnings and checks. > Patch 5 now becomes patch 4. > > The changes have all been tested and work as expected. > > Quentin Armitage (4): > ipvs: Enable setting IPv6 multicast address for ipvs > ipvs: Stop calling __dev_get_by_name() repeatedly when starting sync > daemon > ipvs: Don't check result < 0 after setting result = 0 > ipvs: log additional sync daemon parameters > > net/netfilter/ipvs/ip_vs_sync.c | 105 +++++++++++++++++++-------------------- > 1 files changed, 52 insertions(+), 53 deletions(-) > > -- > 1.7.7.6 You should post first patch separately, not as a part from the patchset, by specifying the tree: [PATCH v4 net] ipvs: ... The other 3 patches remain in this patchset, with added "net-next": [PATCH v4 net-next */3] ipvs: ... Patch 1: It is good to mention that problem happens for link-local addresses, not for site/org-local or global scope. By this way we are more precise when creating a bugfix, it avoids confusion. You can also check again the Subject and the commit message for improvements. It is up to you but here is an example: ipvs: fix bind to link-local mcast IPv6 address in backup The empty line between Fixes and Signed-off-by should be removed. Patch 2-3: look OK Patch 4: Some of the fields are unsigned, so %d should be %u: sync_maxlen, mcast_port, mcast_af, mcast_ttl Regards -- Julian Anastasov <ja@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
