Hi, On Tue, May 10, 2016 at 11:26:56AM +1000, tcharding wrote: > From: Tobin C Harding <me@xxxxxxxx> > > checkpatch produces various white space 'checks'. > > This patch amends them. > > Signed-off-by: Tobin C Harding <me@xxxxxxxx> > --- > This is my second linux kernel patch. Unsure if I was meant to cc multiple mailing lists? > > thanks > > net/bridge/netfilter/ebt_stp.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/net/bridge/netfilter/ebt_stp.c b/net/bridge/netfilter/ebt_stp.c > index 6b731e1..26a0859 100644 > --- a/net/bridge/netfilter/ebt_stp.c > +++ b/net/bridge/netfilter/ebt_stp.c > @@ -55,65 +55,65 @@ static bool ebt_filter_config(const struct ebt_stp_info *info, > if (info->bitmask & EBT_STP_ROOTPRIO) { > v16 = NR16(stpc->root); > if (FWINV(v16 < c->root_priol || > - v16 > c->root_priou, EBT_STP_ROOTPRIO)) > + v16 > c->root_priou, EBT_STP_ROOTPRIO)) I don't think this coding style is right. This is a common approach (to align the condition when split in several lines) in other 'net' code. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html