On Tue, May 24, 2016 at 05:32:43PM +0800, Feng Gao wrote: > Hi Pablo, > > I remember my original commit is very simple. > Just a few lines changes. > > Then I make it more complicated according to your comments Are you refering to this? http://patchwork.ozlabs.org/patch/522709/ I suggested this specifically: "Could you investigate if it would be possible to add a nf_conntrack_helpers_register()?" Then, you followed up with a patchset that was fixing and reworking in the same go. The usual procedure is to split the submissions in logical changes, starting from fixes (that are always prioritized) and then follow up with rework/improvements/new features. I also remember that at some point you withdrew indicating that there was a problem, then came back telling this was OK, which confused me. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html