Re: [PATCH v2 nf-next 7/9] netfilter: conntrack: make netns address part of hash

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2016-05-02 at 18:39 +0200, Florian Westphal wrote:
> Once we place all conntracks into a global hash table we want them to be
> spread across entire hash table, even if namespaces have overlapping ip
> addresses.
>  
> +static inline u32 nf_conntrack_netns_hash(const struct net *net)
> +{
> +#ifdef CONFIG_NET_NS
> +	return hash32_ptr(net);
> +#else
> +	return 0;
> +#endif
> +}
> +

Are you reinventing net_hash_mix() ?

If net_hash_mix() is not good enough, please fix it ;)

hash_ptr() is not that good, as ongoing thread in lkml shows.

Thanks.


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux