Re: [nft PATCH] dist: include tests/ directory and files in tarball

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28 April 2016 at 11:27, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> On Thu, Apr 28, 2016 at 11:14:38AM +0200, Arturo Borrero Gonzalez wrote:
>> If we include tests/ in the release tarball, downstream distributors
>> can run the testsuites themselves while developing the packages.
>>
>> This way, tests can be run in a more integrated environment and they can
>> discover errors related to the integration with the given distribution itself.
>>
>> Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@xxxxxxxxx>
>> ---
>>  Makefile.am |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/Makefile.am b/Makefile.am
>> index 068009b..10aa40f 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -4,3 +4,5 @@ SUBDIRS =     src     \
>>               include \
>>               doc     \
>>               files
>> +
>> +EXTRA_DIST = tests
>
> You can get a git clone instead?
>
> This is going to bloat the tarball for something that only a few
> developer need.

It seems these are the numbers:

In the case of nftables
 * 327K withtout tests
 * 388K with tests

In case of conntrack-tools
 * 496K without tests
 * 503K with tests

I don't think this is a big deal.

Other release tarballs include tests or qa files (libnftnl, ipset,
libnetfilter-conntrack...)

-- 
Arturo Borrero González
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux