Re: [nft PATCH] evaluate: better error reporting in too long sets names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 27 Apr 2016, Pablo Neira Ayuso wrote:

> On Wed, Apr 20, 2016 at 03:43:00PM +0200, Arturo Borrero Gonzalez wrote:
> > Currently, if we choose a set name larger than allowed, the error message is:
> >  Error: Could not process rule: Numerical result out of range
> > 
> > Let's inform the user with a better error message.
> > 
> > We can discuss later if length of set names should be increased, but I think
> > this better error reporting is necessary right now to avoid headaches to users.
> 
> /* The max length of strings including NUL: set and type identifiers */
> #define IPSET_MAXNAMELEN        32
> 
> I would like that we get the same length as ipset, this should make it
> easier for people to migrate.

I think it's all right if set names are longer in nftables. That won't 
cause incompatibilites, unless someone wants to move from nftables to 
ipset.

Best regards,
Jozsef
-
E-mail  : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux