On 25.04, Pablo Neira Ayuso wrote: > On Mon, Apr 25, 2016 at 10:35:19PM +0100, Patrick McHardy wrote: > > On 25.04, Florian Westphal wrote: > > > > > If not, I see no choice other than resubmitting the original V1 kernel > > > patch that simply copied the entire sreg into the label area, this way > > > no userspace changes are needed. > > > > I have to follow up on the previous discussion. Just wondering, what's wrong > > with simply memcpy'ing and supplying the full set of labels? > > How can you make this atomic with a 128 bit connlabel? Good point. But then we already have a theoretical problem in the existing NFT_CT_LABELS support, at least if we're looking at multiple bits at the same time. I'm fine either way, I just wand to understand the reason for the inconsistency between get and set. If we need atomicity, we probably need to make sure that get is either a bitop or we only allow to use a single bit of the result. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
