On 25.04, Florian Westphal wrote: > Patrick McHardy <kaber@xxxxxxxxx> wrote: > > On 24.04, Patrick McHardy wrote: > > > On 25.04, Florian Westphal wrote: > > > > Patrick McHardy <kaber@xxxxxxxxx> wrote: > > > > > The following patches contain the latest version of the ruleset tracing > > > > > functionality. > > > > > I consider this patchset complete. Testing and comments welcome. > > > > > > > > Seems it doesn't work with inet table, I get segfault in expr_print > > > > (EXPR_VALUE expr with expr->dtype == NULL). > > > > > > > > Callchain that produces this expression is: > > > > > > > > trace_gen_stmts -> payload_expr_expand -> payload_expr_alloc > > > > > > > > desc argument to payload_expr_alloc is the inet one, which > > > > has no template for types != 0, so tmpl->dtype that gets passed > > > > to expr_alloc is NULL. > > > > > > Thanks, I'll look into that. > > > > > > > Works fine without inet table. Only "problem" I found is that > > > > nft displays the ether addr reversed vs. what 'ip link' shows, > > > > i.e. if ip link says 1:2:3:4:5:6 nft shows 6:5:4:3:2:1. > > > > > > > > I'll do more tests tomorrow and will double check that its not > > > > a kernel bug. > > > > > > That's just a missing byte order conversion, I've fixed it locally. > > > > This patch should fix both issues. > > It does, thanks! Thanks, I've pushed out the patches. > Seems to work fine now, only missing enhancement would be to add new > rules to the cache; currently when nft monitor is running it > will print out a added rules, but they are not printed out in new trace > events (restarting the nft monitor process works fine). Yes, that would be good to have. Looks like a bit more effort though, we also need to keep all other objects in sync. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
