Re: [PATCH 2/4 v6] libnftnl: rule: Change the "userdata" attribute to use new TLV buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 14, 2016 at 07:55:42PM +0200, Carlos Falgueras García wrote:
> I don't understand. With the modification to the patch [4/4 v6] you made,
> there is still a data copy and it is passed in the same way. This copy has
> moved from libnftnl to nft, but it still exists.

This is an old bug, it's been there for a while.

> There are another 'frees' I think is better to change it for
> 'nftnl_udata_buf_free', although in practice it is the same.

There is no value in using nftnl_udata_buf_free().

nftnl_udata_buf_*() functions are helpers to build the sequence of
TLVs, once this is done, I don't see any good reason to use out of
that context.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux