Re: [PATCH 3/5] netfilter: x_tables: add and use xt_check_entry_target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 25, 2016 at 12:45:53PM +0100, Florian Westphal wrote:
> Florian Westphal <fw@xxxxxxxxx> wrote:
> > +	if (strcmp(t->u.user.name, XT_STANDARD_TARGET) == 0 &&
> > +	    target_offset + sizeof(struct xt_standard_target) > next_offset)
> > +		return -EINVAL;
> 
> The last hunk broke CONFIG_COMPAT, it calls into check_entry() and
> casts compat_Xt_entry to Xt_entry, but for compat case
> xt_standard_target is larger than what a 32bit userspace sends us.
> 
> For now I'd suggest to not pass this to stable, I'll  rework
> the compat handlers next week to fix this properly.

OK, I'll pull this out from the nf tree and rebase.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux