On Wed, Mar 16, 2016 at 12:09:21AM +0100, Florian Westphal wrote: > Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > On Tue, Mar 15, 2016 at 05:10:09PM +0100, Florian Westphal wrote: > > > Instead of taking the value to set from a source register, userspace > > > passes the bit that we should set as a netlink attribute. > > > > > > This follows a similar approach that xtables 'connlabel' > > > match uses, so when user inputs > > > > > > ct label set bar > > > > I think we can introduce: > > > > ct label bitset bar > > > > so this is clear to the user this is just setting the bit at that > > position. > > I don't like this one bit ;) > > Seriously, I think "label set bar" is fine. > > We already treat "ct label foo" correctly without > using "ct label testbit foo", so I like it better > without the extra special-case "bitset" keyword. OK, I don't have a strong opinion on the connlabel usecase, so let's stick to 'label set bar'. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
