Re: [PATCH] src: proto: Add missing packet type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Shivani Bhardwaj <shivanib134@xxxxxxxxx> wrote:
> Add missing packet type "invalid" for DCCP.
> 
> Signed-off-by: Shivani Bhardwaj <shivanib134@xxxxxxxxx>
> ---
>  src/proto.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/proto.c b/src/proto.c
> index 0ed98ed..4d049f5 100644
> --- a/src/proto.c
> +++ b/src/proto.c
> @@ -443,6 +443,7 @@ static const struct symbol_table dccp_pkttype_tbl = {
>  		SYMBOL("reset",		DCCP_PKT_RESET),
>  		SYMBOL("sync",		DCCP_PKT_SYNC),
>  		SYMBOL("syncack",	DCCP_PKT_SYNCACK),
> +		SYMBOL("invalid",	DCCP_PKT_INVALID),

I don't think this is a good idea -- when user asks to match
'invalid' then this will check type == DCCP_PKT_INVALID; however
the correct way would be to ask for type '> synack' (i.e.,
outside of the range of types specified).
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux