On Thu, Feb 11, 2016 at 03:53:16PM +0100, stephane.ml.bryant@xxxxxxxxx wrote:
> From: stephane <stephane.ml.bryant@xxxxxxxxx>
>
> -this creates 2 netlink attribute NLQA_VLAN and NLQA_L2HDR
> -these are filled up for the PF_BRIDGE family on the way to userspace, and
> used on the way back to modify the original skb accordingly
>
> Signed-off-by: Stephane Bryant <stephane.ml.bryant@xxxxxxxxx>
> ---
> include/uapi/linux/netfilter/nfnetlink_queue.h | 7 ++
> net/netfilter/nfnetlink_queue.c | 130 ++++++++++++++++++++++++-
> 2 files changed, 132 insertions(+), 5 deletions(-)
>
> diff --git a/include/uapi/linux/netfilter/nfnetlink_queue.h b/include/uapi/linux/netfilter/nfnetlink_queue.h
> index b67a853..211fcdc 100644
> --- a/include/uapi/linux/netfilter/nfnetlink_queue.h
> +++ b/include/uapi/linux/netfilter/nfnetlink_queue.h
> @@ -30,6 +30,11 @@ struct nfqnl_msg_packet_timestamp {
> __aligned_be64 usec;
> };
>
> +struct nfqnl_msg_vlan {
> + __be16 proto;
> + __u16 tci;
> +} __attribute__ ((packed));
I'd rather use nested attributes instead of passing structures through
netlink.
I'm aware we're using structure in the existing code, that decision
was made long time ago and we cannot change it. But as I said for new
code I'd rather see nested attributes. See nla_nest_start and nla_nest_end.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
