TIMECONV filter in previous patch has private data but does not
have stop callback, then segfault occured.
Signed-off-by: Ken-ichirou MATSUZAWA <chamas@xxxxxxxxxxxxx>
---
src/ulogd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/ulogd.c b/src/ulogd.c
index 5b9a586..7e1a42f 100644
--- a/src/ulogd.c
+++ b/src/ulogd.c
@@ -1288,13 +1288,13 @@ static void stop_pluginstances()
llist_for_each_entry(stack, &ulogd_pi_stacks, stack_list) {
llist_for_each_entry_safe(pi, npi, &stack->list, list) {
- if ((pi->plugin->priv_size > 0 || *pi->plugin->stop) &&
- pluginstance_stop(pi)) {
+ if (*pi->plugin->stop && pluginstance_stop(pi)) {
ulogd_log(ULOGD_DEBUG, "calling stop for %s\n",
pi->plugin->name);
(*pi->plugin->stop)(pi);
- pi->private[0] = 0;
}
+ if (pi->plugin->priv_size > 0)
+ pi->private[0] = 0;
free(pi);
}
}
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
