On 04.02, Florian Westphal wrote: > Florian Westphal <fw@xxxxxxxxx> wrote: > > > > What should happen when user asks for meta random 42.23 ? > > > > That still stands, where would this error be detect best? > > I've also been unable to figure out where the u32 scaling has > to be performed, netlink_linearize.c seems to be a very poor place > for this since it would mean special-casing netlink_gen_cmp > to check for OP_LTE and presence of EXPR_META with the meta PRANDOM > key...? > > In fact, doing the scaling via precision_type seems to > be a lot simpler as then its applied only in this one case of the > prandom META_TEMPLATE while keeping this detail limited to meta.c. Yes, on second thought I agree, sorry. Maybe the work is not lost though, what does seem to make sense is to use a float basetype and derive your probability type from that. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
