On Thu, 28 Jan 2016 06:00:50 -0800 Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote: > On Thu, 2016-01-28 at 21:14 +0800, Zhouyi Zhou wrote: > > > My patch is intend to prevent kernel panic, to prevent reading garbage > > or read data from a prior frame and leak secrets, the prototypes of the > > get_h2x5_addr functions and the functions that call get_h2x5_addr should > > be changed, should we do this? > > In term of security, panics are better than allowing attacker to read > data from other people, like a password. > > BTW, are you able to trigger any panic ? We have a smattering of panics in this code in bugzilla going back years. https://bugzilla.kernel.org/show_bug.cgi?id=12473 etc Alan -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html